Return DBActions from Rollback
#929
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7cea307 to
bee688d
Compare
pkg/migrations/op_add_column.go
Outdated
| l.LogOperationRollback(o) | ||
|
|
||
| table := s.GetTable(o.Table) | ||
| if table == nil { | ||
| return TableDoesNotExistError{Name: o.Table} | ||
| return []DBAction{}, TableDoesNotExistError{Name: o.Table} |
There was a problem hiding this comment.
can we return nil slices rather than empty slices?
The same also applies to the error returns in the Complete functions.
bee688d to
7ad76b2
Compare
Merging this branch changes the coverage (1 decrease, 1 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
andrew-farries
approved these changes
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the signature of
Rollback. From now on, it returns a list ofDBActions.