Move Status method to roll package
#921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Status method to `Roll packageStatus method to roll package
739bbd4 to
390859a
Compare
- Move `Status` type, `MigrationStatus` type, and related constants from `pkg/state/status.go` to `pkg/roll/status.go` - Move `Status` method from `State` receiver to `Roll` receiver - Remove `Status` method from state package This improves the architecture by placing migration status reporting in the roll package where it conceptually belongs, rather than in the low-level state persistence package.
Construct a new `Roll` instance to use the `Status` method.
390859a to
7ad8c74
Compare
Merging this branch will increase overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
kvch
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move
Statusfunctionality fromstatetorollpackage.Refactor the migration status functionality by moving it from the
statepackage to therollpackage.This change improves the architecture by:
Better separation of concerns: The state package should focus purely on persistence operations, while migration status reporting belongs in the roll package alongside other migration orchestration logic
Better test coverage: by moving functionality into the packages that use them, rather than having the functionality of one package tested by tests in another.