Update error type returned when Roll.LatestVersionRemote finds no version schema
#918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
be1e846 to
a4f2b3a
Compare
cece35e to
e553c34
Compare
kvch
approved these changes
Jun 18, 2025
Make `LatestVersionRemote` return a specific error when no version schema is found. This is distinct from the case where no migrations have been applied, as migrations may exist but not have a version schema such as for an inferred migration or a migration craeted with version schema creation disabled.
Ensure that `roll.LatestVersionRemote` returns the expected error: * When migrations have been applied but none have a version schema. * When no migrations have been applied.
e553c34 to
8e58110
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that the error returned by
Roll.LatestVersionRemotewhen there are no version schema in the target database makes it clear that there are no version schema rather than no migrations.When using
Roll.WithVersionSchema(false)it's easy to have a situation where there are migrations applied but no version schema; in that caseRoll.LatestVersionRemoteshould return an appropriate error rather than one that says no migrations have been applied.