Skip to content

Rename WithDisableViewsManagement roll option #917

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 18, 2025

Conversation

andrew-farries
Copy link
Collaborator

Rename the WithDisableViewsManagement option to WithVersionSchema to better reflect its purpose.

Update the test that runs a migration with the option set to include a rollback.

Part of #872

@github-actions github-actions bot temporarily deployed to Docs Preview June 17, 2025 15:27 Inactive
@andrew-farries andrew-farries marked this pull request as ready for review June 18, 2025 06:47
@andrew-farries andrew-farries requested a review from kvch June 18, 2025 06:47
Base automatically changed from fix-pgroll-latest-schema-with-inferred-migs to main June 18, 2025 07:40
Rename the `WithDisableViewsManagement` option to `WithVersionSchema` to
better reflect its purpose.
@andrew-farries andrew-farries force-pushed the rename-disable-view-management-option branch from be1e846 to a4f2b3a Compare June 18, 2025 07:41
@github-actions github-actions bot temporarily deployed to Docs Preview June 18, 2025 07:41 Inactive
Copy link

Merging this branch will not change overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgroll/pkg/roll 79.87% (ø)

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgroll/pkg/roll/options.go 66.67% (ø) 15 10 5

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/xataio/pgroll/pkg/roll/execute_test.go

@andrew-farries andrew-farries merged commit 3532502 into main Jun 18, 2025
30 checks passed
@andrew-farries andrew-farries deleted the rename-disable-view-management-option branch June 18, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants