Skip to content

Add new DBAction: RenameDuplicatedColumnAction #883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2025

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jun 11, 2025

This PR transforms RenameDuplicatedColumn to a DBAction. It consists of multiple DBActions. It might be
more elegant if it returned a list of DBActions instead. But for now, it is good enough for the upcoming extraction
of the cleanup phase from complete and rollback.

Related to #742

@github-actions github-actions bot temporarily deployed to Docs Preview June 11, 2025 15:41 Inactive
Copy link

Merging this branch will decrease overall coverage

Impacted Packages Coverage Δ 🤖
github.com/xataio/pgroll/pkg/migrations 74.04% (-0.01%) 👎

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/xataio/pgroll/pkg/migrations/op_alter_column.go 83.74% (ø) 123 103 20
github.com/xataio/pgroll/pkg/migrations/op_create_constraint.go 77.97% (ø) 118 92 26
github.com/xataio/pgroll/pkg/migrations/op_drop_constraint.go 80.00% (ø) 65 52 13
github.com/xataio/pgroll/pkg/migrations/op_drop_multicolumn_constraint.go 82.50% (ø) 80 66 14
github.com/xataio/pgroll/pkg/migrations/rename.go 81.82% (-0.40%) 44 (-1) 36 (-1) 8 👎

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

@kvch kvch requested a review from andrew-farries June 11, 2025 15:51
@kvch kvch merged commit f672053 into main Jun 12, 2025
30 checks passed
@kvch kvch deleted the refactoring-rename-column-dbaction branch June 12, 2025 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants