Use existing dbactions in op_alter_column
#879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
44b15a5 to
ab6d1d0
Compare
ab6d1d0 to
12a92f1
Compare
12a92f1 to
c659fd5
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. |
kvch
commented
Jun 11, 2025
| conn, | ||
| table.Name, | ||
| NotNullConstraintName(o.Column.Name), | ||
| fmt.Sprintf("%s IS NOT NULL", o.Column.Name), |
There was a problem hiding this comment.
I am not passing TemporaryName(o.Column.Name) because the action takes care of rewriting the check expression.
kvch
commented
Jun 11, 2025
| conn, | ||
| table.Name, | ||
| o.Column.Check.Name, | ||
| o.Column.Check.Constraint, |
There was a problem hiding this comment.
I am not rewriting the expression here because the action takes care of it.
kvch
commented
Jun 11, 2025
| conn, | ||
| table.Name, | ||
| NotNullConstraintName(o.Column), | ||
| fmt.Sprintf("%s IS NOT NULL", o.Column), |
There was a problem hiding this comment.
I am not rewriting the expression here because the action takes care of it.
andrew-farries
approved these changes
Jun 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #742