-
Notifications
You must be signed in to change notification settings - Fork 105
Add more details to update
subcommand page
#877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the guide can be much simpler; maybe so much so that it could be part of the doc page for the update
command itself.
I don't think we need to distinguish the case where you update whatever files you have locally vs pulling first and then updating.
The doc only needs to:
- explain why you'd want to run
pgroll update
(the breaking change case you describe here). - give an example of how you use it against a local
migrations/
folder.
I'd be in favour of putting that in the docs for the update
command and not having this guide.
docs/guides/updatemigrations.mdx
Outdated
In this guide, we are going to learn how to update `pgroll` migration files in case there is a breaking change in the latest release. | ||
|
||
<Warning> | ||
`pgroll` hasn't reached v1 yet, so we are releasing breaking changes from time to time. Adopting these changes can be painful manually. We suggest you use the subcommand `update` to make sure all your local migrations are correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
`pgroll` hasn't reached v1 yet, so we are releasing breaking changes from time to time. Adopting these changes can be painful manually. We suggest you use the subcommand `update` to make sure all your local migrations are correct. | |
`pgroll` hasn't reached v1 yet, so we are releasing breaking changes from time to time. Adopting these changes can be painful manually. We suggest you use `pgroll update` to make sure all your local migrations are correct. |
pgroll
update
subcommand page
Explain what the command is used for.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added one more commit to the branch to add some context about what the command is for.
Thank you! |
This PR adds more details to
update
command.Requires #855