Skip to content

Add more details to update subcommand page #877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 30, 2025
Merged

Add more details to update subcommand page #877

merged 5 commits into from
Jun 30, 2025

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Jun 10, 2025

This PR adds more details to update command.

Requires #855

@github-actions github-actions bot temporarily deployed to Docs Preview June 10, 2025 16:01 Inactive
@kvch kvch force-pushed the docs-update-guide branch from b35145a to e71e81d Compare June 10, 2025 16:11
@github-actions github-actions bot temporarily deployed to Docs Preview June 10, 2025 16:11 Inactive
@kvch kvch force-pushed the docs-update-guide branch from e71e81d to a6fc85e Compare June 10, 2025 16:15
@github-actions github-actions bot temporarily deployed to Docs Preview June 10, 2025 16:15 Inactive
@kvch kvch requested a review from andrew-farries June 13, 2025 14:29
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the guide can be much simpler; maybe so much so that it could be part of the doc page for the update command itself.

I don't think we need to distinguish the case where you update whatever files you have locally vs pulling first and then updating.

The doc only needs to:

  • explain why you'd want to run pgroll update (the breaking change case you describe here).
  • give an example of how you use it against a local migrations/ folder.

I'd be in favour of putting that in the docs for the update command and not having this guide.

In this guide, we are going to learn how to update `pgroll` migration files in case there is a breaking change in the latest release.

<Warning>
`pgroll` hasn't reached v1 yet, so we are releasing breaking changes from time to time. Adopting these changes can be painful manually. We suggest you use the subcommand `update` to make sure all your local migrations are correct.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`pgroll` hasn't reached v1 yet, so we are releasing breaking changes from time to time. Adopting these changes can be painful manually. We suggest you use the subcommand `update` to make sure all your local migrations are correct.
`pgroll` hasn't reached v1 yet, so we are releasing breaking changes from time to time. Adopting these changes can be painful manually. We suggest you use `pgroll update` to make sure all your local migrations are correct.

@kvch kvch changed the title Add guide for update command Add guide for updating pgroll Jun 25, 2025
@kvch kvch changed the title Add guide for updating pgroll Add more details to update subcommand page Jun 25, 2025
@kvch kvch force-pushed the docs-update-guide branch from a6fc85e to f816a8d Compare June 25, 2025 09:47
@github-actions github-actions bot temporarily deployed to Docs Preview June 25, 2025 09:47 Inactive
@github-actions github-actions bot temporarily deployed to Docs Preview June 25, 2025 09:48 Inactive
@kvch kvch requested a review from andrew-farries June 25, 2025 09:50
Explain what the command is used for.
@github-actions github-actions bot temporarily deployed to Docs Preview June 30, 2025 08:20 Inactive
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added one more commit to the branch to add some context about what the command is for.

@kvch
Copy link
Contributor Author

kvch commented Jun 30, 2025

Thank you!

@kvch kvch merged commit 063a244 into main Jun 30, 2025
30 checks passed
@kvch kvch deleted the docs-update-guide branch June 30, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants