Skip to content

Fail early in migrate if there is an incompatible migration file #827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
May 19, 2025

Conversation

kvch
Copy link
Contributor

@kvch kvch commented May 12, 2025

This PR changes the migrate command. It does not start any migrations before it makes sure that the outstanding migration files are compatible with the current version.

Closes #766

@github-actions github-actions bot temporarily deployed to Docs Preview May 12, 2025 11:38 Inactive
@kvch kvch force-pushed the feature-fail-early-if-incompatible branch from cd9f5eb to b15a2aa Compare May 16, 2025 13:59
@github-actions github-actions bot temporarily deployed to Docs Preview May 16, 2025 14:00 Inactive
@kvch kvch marked this pull request as ready for review May 16, 2025 14:00
@kvch kvch requested a review from andrew-farries May 16, 2025 14:00
@github-actions github-actions bot temporarily deployed to Docs Preview May 16, 2025 14:07 Inactive
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, one suggested change 👍

@github-actions github-actions bot temporarily deployed to Docs Preview May 16, 2025 15:34 Inactive
@github-actions github-actions bot temporarily deployed to Docs Preview May 16, 2025 15:37 Inactive
@kvch kvch force-pushed the feature-fail-early-if-incompatible branch from 3b001b4 to fe1b3d8 Compare May 16, 2025 15:39
@github-actions github-actions bot temporarily deployed to Docs Preview May 16, 2025 15:39 Inactive
@github-actions github-actions bot temporarily deployed to Docs Preview May 16, 2025 15:45 Inactive
@github-actions github-actions bot temporarily deployed to Docs Preview May 16, 2025 15:50 Inactive
@kvch kvch requested a review from andrew-farries May 16, 2025 15:50
Co-authored-by: Andrew Farries <andyrb@gmail.com>
@github-actions github-actions bot temporarily deployed to Docs Preview May 19, 2025 08:20 Inactive
@kvch kvch requested a review from andrew-farries May 19, 2025 08:22
@github-actions github-actions bot temporarily deployed to Docs Preview May 19, 2025 08:22 Inactive
@kvch kvch merged commit 99819d6 into xataio:main May 19, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail early in case there is a breaking change in pgroll
2 participants