Skip to content

Conversation

kvch
Copy link
Contributor

@kvch kvch commented May 9, 2025

This PR adds a new type MigrationWriter to provied a unified way to write migrations
to file either in YAML or in JSON format. It is used in 3 commands: convert, create and pull.

Also with this change I added a new flag to convert called json. Previously, the command serialized migrations
into JSON format. From now on, it follows the same pattern like create and pull. It writes migrations in YAML format unless the user sets --json flag.

@github-actions github-actions bot temporarily deployed to Docs Preview May 9, 2025 11:28 Inactive
@github-actions github-actions bot temporarily deployed to Docs Preview May 9, 2025 11:30 Inactive
@github-actions github-actions bot temporarily deployed to Docs Preview May 9, 2025 11:47 Inactive
@kvch kvch requested a review from andrew-farries May 9, 2025 11:47
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change 👍

It's currently broken though because marshalling YAML always returns an error 😛

@github-actions github-actions bot temporarily deployed to Docs Preview May 12, 2025 09:36 Inactive
@kvch kvch merged commit cc8fa32 into xataio:main May 13, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants