Make pgroll pull pull only migrations that don't exist in target directory
#811
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
reviewed
Apr 30, 2025
kvch
approved these changes
Apr 30, 2025
1b987a2 to
fe22159
Compare
7de38ec to
6c79470
Compare
`MissingMigrations` returns the slice of migrations that have been applied to the target database but are missing from the local migrations directory `dir`. If the local order of migrations does not match the order of migrations in the schema history, an `ErrMismatchedMigration` error is returned.
Make the `pgroll pull` command pull only those migrations from the target database that are missing in the local directory. This ensures that existing migrations in the local directory are not overwritten or modified when pulling from the target database, for example with formatting or order-of-field changes.
fe22159 to
067f019
Compare
andrew-farries
added a commit
that referenced
this pull request
May 8, 2025
Ensure that when no migrations have been applied to the target database, the `MissingMigrations` function returns an empty slice. Also, update an error message in the pull command to be more accurate. This should have been part of #811
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the
pgroll pullcommand pull only those migrations from the target database that are missing in the local directory.This ensures that existing migrations in the local directory are not overwritten or modified when pulling from the target database, for example with formatting or order-of-field changes.