Skip to content

Remove name field from all examples #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 29, 2025
Merged

Conversation

andrew-farries
Copy link
Collaborator

Remove the name field from all example migrations.

Migration names now default to the file name if a name field is not present and we recommend that approach over explicitly naming the migration in the JSON/YAML.

@github-actions github-actions bot temporarily deployed to Docs Preview April 28, 2025 09:01 Inactive
@andrew-farries andrew-farries marked this pull request as ready for review April 28, 2025 09:04
@andrew-farries andrew-farries requested a review from kvch April 28, 2025 09:04
Copy link
Contributor

@kvch kvch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look good. Do you want to remove name from other documentation pages as well like in the tutorial page?

@andrew-farries
Copy link
Collaborator Author

The changes look good. Do you want to remove name from other documentation pages as well like in the tutorial page?

It's a good point - I'll go through the docs and remove name fields there too.

State that it's recommended not to use the name field in the migration.
@andrew-farries andrew-farries force-pushed the remove-name-from-examples branch from 34ca210 to 3419d7e Compare April 29, 2025 14:45
@github-actions github-actions bot temporarily deployed to Docs Preview April 29, 2025 14:46 Inactive
@andrew-farries andrew-farries merged commit 7669ae2 into main Apr 29, 2025
30 checks passed
@andrew-farries andrew-farries deleted the remove-name-from-examples branch April 29, 2025 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants