Add fallback method for backfilling records #779
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbdfc03 to
bf0d0ad
Compare
ac748b3 to
7d194cf
Compare
7d194cf to
953ce19
Compare
exekias
reviewed
Apr 7, 2025
| "github.com/xataio/pgroll/pkg/backfill/templates" | ||
| "github.com/xataio/pgroll/pkg/db" | ||
| "github.com/xataio/pgroll/pkg/schema" | ||
| ) | ||
|
|
||
| const CNeedsBackfillColumn = "_pgroll_needs_backfill" |
exekias
approved these changes
Apr 7, 2025
|
I added one more test and a comment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
pgrollcould not backfill tables that did not have a primary key or a unique column. From now on,pgrollcan fallback onto the internal column_pgroll_needs_backfillto find all columns that has to be backfilled.I also moved
CNeedsBackfillColumnconstant to the packagebackfillbecause it makes more sense to have it there.Required by #698