Implement creating a unique index concurrently as a DBAction
#747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
59a7a79 to
ecb7182
Compare
pkg/migrations/dbactions.go
Outdated
| if a.schemaName != "" { | ||
| quotedQualifiedIndexName = fmt.Sprintf("%s.%s", pq.QuoteIdentifier(a.schemaName), pq.QuoteIdentifier(a.indexName)) | ||
| } | ||
| for retryCount := 0; retryCount < 5; retryCount++ { |
There was a problem hiding this comment.
Can use a range over int statement here instead.
for range 5 {d1c6d92 to
f03c9dc
Compare
andrew-farries
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
IIRC, we don't have automated tests to check #485.
It would be worth running through one of the reproductions there to ensure that creating indexes under load is still fixed after this extraction.
f03c9dc to
6140005
Compare
6140005 to
3d40e1e
Compare
|
I tested the scenario in the issue mentioned. The issue is not coming back when we merge this change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements creating unique indexes concurrently as a
DBAction. Looking at the implementation of the action, we can refactor it in a later PR and introduce aCreateIndexSQLWritersimilar toConstraintSQLWriter. But this is a problem for a future PR.