Rename generate and format jobs #734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
approved these changes
Mar 21, 2025
Don't have `generate` depend on `format`.
Separate the type generation and formatting steps into separate jobs. Refer to 'code generation' rather than 'type generation' as the job generates both types and code.
8e59e90 to
dd3530a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the
type-generationjob into to separateformatandcode-generationjobs.Previously, the
type-generationjob could fail for a variety of reasons related to either formatting, type generation, or CLI definition JSON generation.This change will make build failures easier to diagnose.