Improve create_index operation with extra index element settings
#697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ea5c5a9 to
f646e8a
Compare
f646e8a to
62b06b9
Compare
kvch
commented
Feb 26, 2025
|
This PR is ready for review, but |
docs/operations/create_index.mdx
Outdated
Comment on lines
20
to
23
| "params": { | ||
| "param1": "val", | ||
| "param2": "val" | ||
| } |
There was a problem hiding this comment.
I think this doc is out of date now that params was changed to a slice of strings rather than a map.
3d0647e to
f0a1574
Compare
andrew-farries
approved these changes
Feb 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a breaking change to
create_indexoperation. From now oncolumnsdoes not accept a list of column names. Instead it expects a map, so we can support for additional index elements settings.New settings:
collation: name of the collation to use on the columnopclass:opclass.namesets the name of the operator class andopclass.paramsexpects a KV pairs for operator class settingssort: change the ordering (ASCorDESC)nulls: change the position of null values in the index (FIRSTorLAST)