Support parsing multiple SQL statements in sql2pgroll.Convert
#690
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
commented
Feb 18, 2025
b92cd27 to
235b2f7
Compare
235b2f7 to
25d7008
Compare
There was a problem hiding this comment.
Left some comments.
More generally, could the signature of Convert remain as returning a slice of operations? The process of putting them into a Migration and generating a name for the migration seems like functionality that should be in whatever is calling Convert, not in Convert itself.
25d7008 to
54bed01
Compare
|
@andrew-farries I have reworked the pull request to keep the signature of |
sql2pgroll.Convert to return Migration and parse multiple statementssql2pgroll.Convert
54bed01 to
0e3748f
Compare
andrew-farries
approved these changes
Feb 19, 2025
pkg/sql2pgroll/convert_test.go
Outdated
| expectedErr bool | ||
| }{ | ||
| "empty SQL statement": { | ||
| sql: "", |
There was a problem hiding this comment.
could fill in the expectedOps and expectedErr fields here too.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces support for translating multiple SQL statements to pgroll operations in
sql2pgroll.Convert.This PR required by the upcoming improvements to support reading complete SQL migration
files produced by ORMs.