Support table and column rename operations preceding create_constraint FOREIGN KEY operations
#682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the physical table name when adding a foreign key constraint. This ensures that if the table has been renamed in the in-memory schema by an earlier operation, the correct table name is used when adding the constraint.
kvch
approved these changes
Feb 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
create_constraintFOREIGN KEYoperations can be preceded by rename table and rename column operations as in the following example:{ "name": "22_multiple_ops", "operations": [ { "rename_table": { "from": "items", "to": "products" } }, { "rename_column": { "table": "products", "from": "owner", "to": "owner_id" } }, { "create_constraint": { "table": "products", "type": "foreign_key", "name": "fk_items_users", "columns": ["owner_id"], "references": { "table": "users", "columns": ["id"] }, "up": { "owner_id": "owner_id" }, "down": { "owner_id": "owner_id" } } } ] }Follow up to #674 and #676.
Part of #239.