Update Operation.Start signature to remove callbacks parameter
#675
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove the `...backfill.CallbackFn` variadic parameter from the `Start` method of the `Operation` interface and all its implementations.
It was passed to each `op.Start` but never used otherwise.
kvch
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
...backfill.CallbackFnvariadic parameter from theStartmethod of theOperationinterface and all its implementations.The parameter was passed to all
Startmethods of all operations but not used. This is likely left over from when backfill was moved out of individual operations and into a separate step when all DDL was complete (#289).