Improve validation of create_table and add_column operations
#666
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that a `Column` has all required fields needed to create it.
All columns in create table statements need to be valid themselves (ie have no missing required fields).
kvch
approved these changes
Feb 7, 2025
Yes, the JSON schema will reject these errors. We should use JSON schema validation in I created #673 to start doing JSON validation in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve validation of
create_tableandadd_columnoperations.Previously, these operations would fail at migration
Startif one of the column definitions was invalid due to having a missingnameortypefield.This PR adds extra validation checks to both operations to ensure that such migrations fail at the validation stage instead.