Skip to content

Move ConstraintSQLWriter to a separate file #665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 10, 2025

Conversation

kvch
Copy link
Contributor

@kvch kvch commented Feb 7, 2025

This PR moves ConstraintSQLWriter from op_create_table into its own file.
The struct is used in multiple operations, so it belongs to a dedicated file.

I added comments and unit tests.

Add comments and unit tests
@kvch kvch requested a review from andrew-farries February 7, 2025 12:55
Copy link
Collaborator

@andrew-farries andrew-farries left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks for adding all the comments 👍

@kvch kvch merged commit cad53be into xataio:main Feb 10, 2025
28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants