Move backfill options to start and migrate command
#660
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
08a7668 to
ae056d6
Compare
ae056d6 to
4dcd097
Compare
There was a problem hiding this comment.
I think this has broken the flags - they aren't taking effect for me:
Apply the migration:
{
"name": "01_create_table",
"operations": [
{
"create_table": {
"name": "items",
"columns": [
{
"name": "id",
"type": "serial",
"pk": true
},
{
"name": "name",
"type": "text"
}
]
}
}
]
}Fill the table with data:
insert into items(name) select 'name_' || i from generate_series(1, 1_000_000) as iStart a migration with a specified delay:
go run . start --backfill-batch-delay=10s 02_set_unique.jsonwhere the migration is defined:
{
"name": "02_set_unique",
"operations": [
{
"alter_column": {
"table": "items",
"column": "name",
"unique": {
"name": "items_name_unique"
},
"up": "name",
"down": "name"
}
}
]
}There is no delay between each batch during the backfill.
I think the problem is how the flags are defined as PersistentFlags in the start and migrate commands.
|
Fixed the issue |
andrew-farries
approved these changes
Feb 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the flags
backfill-batch-delayandbackfill-batch-sizetothe commands
startandmigrate. So these options no longer show up in the listof global flags.
I created a new struct
backfill.Configto store and pass the options downto the migration runner. I also moved the default values for batch delay and batch size
into the package
backfill. I renamedoptions.gotoconfig.gobecause it is a better name given the new contents of the file.Closes #657