-
Notifications
You must be signed in to change notification settings - Fork 105
Unify table level foreign key conversion in sql2pgroll
#628
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
commented
Jan 28, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this looks good 👍
It would be good to separate out the simpler changes (eg constant renames) from other changes so that individual PRs don't get too big.
Requires #639. |
kvch
added a commit
that referenced
this pull request
Jan 29, 2025
This PR renames `ForeignKeyReferenceOnDelete` to `ForeignKeyAction`. The name was too long. Also, `ON DELETE` and `ON UPDATE` referential actions are the same. This name makes it clearer that we are reusing this enum for both options. Extracted from #628
This was referenced Jan 29, 2025
kvch
added a commit
that referenced
this pull request
Feb 3, 2025
This PR adds support for creating not validated constraints in `ALTER TABLE` statements. I am adding unit tests in a follow-up PR, when `ConstraintSQLWriter` is moved into a separate file. Either way, it is not used anywhere yet to avoid conflicts with other FK related changes in future PRs. Extracted from #628
kvch
added a commit
that referenced
this pull request
Feb 4, 2025
This PR adds the missing `match_type` configuration to `ConstraintSQLWriter`. Tests are coming in a follow-up PR when the `ConstraintSQLWriter` gets its own file. Extracted from #628
kvch
added a commit
that referenced
this pull request
Feb 6, 2025
…`create_constraint` (#653) Now more foreign key options are supported: * `match_type` in column definitions and in `create_constraint` * `on_update` in column definitions and in `create_constraint` * `on_delete_set_columns` in `create_constraint` * `on_update` in inline FK definitions in a column's `references` * `match_type` in inline FK definction in a column's `references` Extracted from #628. The only remaining part of that PR is adding support in `sql2pgroll`. 🎉
create_table
, create_constraint
and column level constraintssql2pgroll
andrew-farries
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR unifies FK constraints in
sql2pgroll
package. The new functionconvertFkConstraint
in is the unified way to process table level FK constraints of columns and tables.