Skip to content

Move backfill code from pkg/migrations to new pkg/backfill package #627

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jan 28, 2025
Merged

Move backfill code from pkg/migrations to new pkg/backfill package #627

merged 4 commits into from
Jan 28, 2025

Conversation

andrew-farries
Copy link
Collaborator

Move the backfill code from the pkg/migrations package to its own pkg/backfill package.

Backfill will require some more changes as part of #583 and following work to make backfill resumable.

The changes are all mechanical except:

  • Change the Backfill function name to Start so that it can be invoked as backill.Start rather than backfill.Backfill
  • Export and rename the checkBackfill method to IsPossible.

This is the first part of #583

@andrew-farries andrew-farries marked this pull request as ready for review January 27, 2025 13:14
@andrew-farries andrew-farries merged commit 5e8c6db into main Jan 28, 2025
28 checks passed
@andrew-farries andrew-farries deleted the move-backfill-to-package branch January 28, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kvch kvch kvch approved these changes

@exekias exekias Awaiting requested review from exekias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andrew-farries @kvch