Add support for alter_table set references operations in multi-operation migrations
#621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a FK constraint to a column, take the table and column name from the virtual schema instead of the operation. This ensures that the operation is aware of any table and column renames that were done by previous operations in the same migration.
Take the name of the referenced table from the virtual schema instead of the operation. This ensures that the correct table name is used when the referenced table has been renamed by a preceding operation in the same migration.
Take the name of the referenced column from the virtual schema instead of the operation. This ensures that the correct column name is used when the referenced column has been renamed by a preceding operation in the same migration.
fd06108 to
1e8375a
Compare
kvch
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that multi-operation migrations combining
alter_columnoperations setting foreign key constraints work in combination with other operations.Add testcases for:
Previously these migrations would fail as the
alter_columnoperation was unaware of the changes made by the preceding operation.Part of #239