Skip to content

Use official goreleaser/goreleaser-cross image #619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

andrew-farries
Copy link
Collaborator

Stop using the custom goreleaser-cross image that was built as part of used as the container in which to build the project for multiple platforms. The image provides C toolchains for all the platforms supported by pgroll.

The official image now uses goreleaser v2.4.8 which contains the fix for the bug (goreleaser/goreleaser#5298) that we were using the custom image to work around.

Follow up to #604 that updated the image elsewhere in the workflow but forgot to update this one.

@andrew-farries andrew-farries marked this pull request as ready for review January 22, 2025 10:26
Base automatically changed from fix-cross-platform-build to main January 22, 2025 11:11
Stop using the custom `goreleaser-cross` image that was built as part of
used as the container in which to build the project for multiple
platforms. The image provides C toolchains for all the platforms
supported by `pgroll`.

The official image now uses `goreleaser` `v2.4.8` which contains the fix
for the bug (goreleaser/goreleaser#5298) that we
were using the custom image to work around.
@andrew-farries andrew-farries force-pushed the use-official-gorelease-cross-image branch from b605828 to 18e26f8 Compare January 22, 2025 11:12
@andrew-farries andrew-farries merged commit 1214e52 into main Jan 22, 2025
28 checks passed
@andrew-farries andrew-farries deleted the use-official-gorelease-cross-image branch January 22, 2025 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants