Add support for alter_table set NOT NULL operations with rename_table operations
#606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that a column on a table that has been renamed by a rename table operation in the same migration can be set to `NOT NULL`.
Use the physical table name instead of the logical table name when adding the `NOT NULL` constraint.
Use the physical table name when creating triggers rather than the logical table name. This means the operation `Start` will work if the table has been renamed by a previous operation; in this case the logical table name will be different from the physical table name.
Use the physical table name instead of the logical table name in the `OpAlterColumn.Rollback` method. This ensures the operation rolls back correctly if the table has been renamed by a preceding operation in the same migration.
Add the table to the in-memory schema representation in the `OpCreateTable.Complete` method. This ensures the table is available to subsequent `Complete`s of operations in the same migration.
Rename the table in the virtual schema so that the `Complete` methods of subsequent operations in the same migration can find it. Also update the physical name of the table in the virtual schema now that it has really been renamed.
kvch
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that multi-operation migrations combining
alter_columnSET NOT NULLandrename_tableoperations work as expected.{ "name": "06_multi_operation", "operations": [ { "rename_table": { "from": "items", "to": "products" } }, { "alter_column": { "table": "products", "column": "name", "nullable": false, "up": "SELECT CASE WHEN name IS NULL THEN 'anonymous' ELSE name END", "down": "name || '_from_down_trigger'" } } ] }This migration renames a table and then sets a column's
nullabilityon the renamed table.Previously the migration would fail as the
alter_columnoperation was unaware of the changes made by the preceding operation.Part of #239