Use official goreleaser/goreleaser-cross image for cross-platform builds
#604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stop using the custom image that was built as part of #525 and use an offcial `gorelaser-cross` image instead. The image is used as the container in which to build the project for multiple platforms. The image provides C toolchains for all the platforms supported by `pgroll`. The official image now uses `goreleaser` `v2.4.8` which contains the fix for the bug (goreleaser/goreleaser#5298) that we were using the custom image to work around.
goreleaseer/goreleaser-cross imagegoreleaser/goreleaser-cross image for cross-platform builds
exekias
approved these changes
Jan 17, 2025
andrew-farries
added a commit
that referenced
this pull request
Jan 22, 2025
Stop using the custom `goreleaser-cross` image that was built as part of used as the container in which to build the project for multiple platforms. The image provides C toolchains for all the platforms supported by `pgroll`. The official image now uses `goreleaser` `v2.4.8` which contains the fix for the bug (goreleaser/goreleaser#5298) that we were using the custom image to work around. Follow up to #604 that updated the image elsewhere in the workflow but forgot to update this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stop using the custom
goreleaser-crossimage that was built as part of #525 and use an officialgorelaser-crossimage instead. The image is used as the container in which to build the project for multiple platforms. The image provides C toolchains for all the platforms supported bypgroll.The official image now uses
goreleaserv2.4.8which contains the fix for the bug (goreleaser/goreleaser#5298) that we were using the custom image to work around.