Add OpRenameColumn for renaming columns
#602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
371826b to
96548b4
Compare
Generate the type for `OpRenameColumn`.
Change the examples that rename a column to use the new `OpRenameColumn` operation.
Add docuementation for the `rename_column` operation. Remove references to renaming columns with the `alter_column` operation.
96548b4 to
6b1ce47
Compare
kvch
approved these changes
Jan 17, 2025
andrew-farries
added a commit
that referenced
this pull request
Jan 17, 2025
…603) Remove the ability to rename columns with `alter_column` operations. #602 added the `rename_column` operation as the preferred way to rename columns: ```json { "name": "13_rename_column", "operations": [ { "rename_column": { "table": "employees", "from": "role", "to": "job_title" } } ] } ``` As of this PR, `rename_column` operations are the only way to rename columns, with the ability to do so using `alter_column` operations removed. This is a breaking change to the `pgroll` migrations format. This is the second (and final) part of #601 Closes #601
kvch
pushed a commit
to kvch/pgroll
that referenced
this pull request
Jan 20, 2025
…ataio#603) Remove the ability to rename columns with `alter_column` operations. xataio#602 added the `rename_column` operation as the preferred way to rename columns: ```json { "name": "13_rename_column", "operations": [ { "rename_column": { "table": "employees", "from": "role", "to": "job_title" } } ] } ``` As of this PR, `rename_column` operations are the only way to rename columns, with the ability to do so using `alter_column` operations removed. This is a breaking change to the `pgroll` migrations format. This is the second (and final) part of xataio#601 Closes xataio#601
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new
rename_columnoperation for performing column renames:{ "name": "13_rename_column", "operations": [ { "rename_column": { "table": "employees", "from": "role", "to": "job_title" } } ] }Renaming columns is currently done using the
alter_columnoperation:{ "name": "13_rename_column", "operations": [ { "alter_column": { "table": "employees", "column": "role", "name": "job_title" } } ] }As of this PR both approaches are valid, but the second approach (using
alter_columnto perform column renames) will be removed as part of #601Part of #601