Multi-operation migration support for alter_column rename operations
#593
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvch
approved these changes
Jan 14, 2025
9408cd8 to
4015541
Compare
3158358 to
a0bbb56
Compare
4015541 to
e726c8e
Compare
a0bbb56 to
d8f886a
Compare
Rename the column back to its original name in the virtual schema on `OpAlterColumn.Rollback` if required. This ensures that `Rollback` operations that precede this operation can find the column in the schema under the name that they expect.
Ensure that a column can be renamed in a table that has been renamed by a previous operation in the same migration.
If the column is being renamed, make that change in the virtual schema so that subsequent operations can validate using the new column name.
d8f886a to
345ed26
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that
alter_columnrename column operations can be used as part of multi-operation migrations:Add testcases for:
Update the
RollbackandValidatemethods to be aware of the effect of previous operations in the same migration and make sure their own changes are visible to other operations in the same migration.Part of #239