Fall back to raw SQL for NOT VALID foreign key constraints
#539
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`pgroll` currently always validates foreign key constraints. If NOT VALID is specified as part of the SQL, then fall back to a raw SQL operation.
ryanslade
approved these changes
Dec 16, 2024
exekias
approved these changes
Dec 16, 2024
c68ba72
into
convert-add-check-constraint
28 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update how
sql2pgrollhandles conversion ofALTER TABLE ... ADD CONSTRAINT ... FOREIGN KEYstatements.Fall back to raw SQL if
NOT VALIDis specified as part of anALTER TABLE ... ADD CONSTRAINT ... FOREIGN KEYstatement becauseOpCreateMultiColumnConstraintcurrently always validates foreign key constraints.