Test cross platform pgroll builds in the CI workflow
#525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f89661d to
fb17847
Compare
ryanslade
approved these changes
Dec 11, 2024
andrew-farries
added a commit
that referenced
this pull request
Dec 13, 2024
… job (#527) Make the `release` job run in a `goreleaser/goreleaser-cross` container so that we can build binaries for all supported architectures. See the PR description for #525 for details of why we need a cross-compilation toolchain as a result of taking a dependency on `pg_query_go` and how the the `goreleaser-cross` image is used. The addition of the `-static` `LDFLAG` for the `linux/amd64` and `linux/arm64` builds is necessary to statically link in order for the resulting `pgroll` binaries to run in the `FROM scratch` image that `Goreleaser` uses to build docker images. Also, revert #515 to re-add the `pgroll sql` command now that `pgroll` can be built for all platforms when the dependency on `pg_query_go` is included in the build.
andrew-farries
added a commit
that referenced
this pull request
Jan 17, 2025
Stop using the custom image that was built as part of #525 and use an offcial `gorelaser-cross` image instead. The image is used as the container in which to build the project for multiple platforms. The image provides C toolchains for all the platforms supported by `pgroll`. The official image now uses `goreleaser` `v2.4.8` which contains the fix for the bug (goreleaser/goreleaser#5298) that we were using the custom image to work around.
andrew-farries
added a commit
that referenced
this pull request
Jan 17, 2025
…uilds (#604) Stop using the custom `goreleaser-cross` image that was built as part of #525 and use an official `gorelaser-cross` image instead. The image is used as the container in which to build the project for multiple platforms. The image provides C toolchains for all the platforms supported by `pgroll`. The official image now uses `goreleaser` `v2.4.8` which contains the fix for the bug (goreleaser/goreleaser#5298) that we were using the custom image to work around.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building
pgrollnow requires a functioning C toolchain on each platform we aim to support, due to taking a dependency on pg_query_go for thesql2pgrollpackage: pg_query_go requiresCGO_ENABLEDto build.This PR adds a new
cross-buildjob in the CI workflow to buildpgrollbinaries for each of our supported platforms:linux/amd64linux/arm64darwin/amd64darwin/arm64windows/amd64The job runs in a goreleaser/goreleaser-cross container in order to have access to a functioning C toolchain for each of the above platforms. The
buildssection of the.goreleaser.yamlconfig file is extended with anoverridessection to configure the C compiler for each platform build:The values for the
CCenv var set the C compiler to use for each OS/Arch target and are taken from the goreleaser-cross docs. The Windows build requires extra linker flags:due to having to link to the libssp stack-protection library and statically link to avoid the runtime dependency on that library.
The job runs in a
surjection/goreleaser-cross:v1.23-v2.4.8container, which is NOT an official goreleaser/goreleaser-cross image. This image was built with thisDockerfile:ie it installs the latest version Goreleaser
2.4.8into the most recentgoreleaser/goreleaser-crossimage. Once agoreleaser/goreleaser-crossimage usinggoreleaser2.4.8is released we can switch back to the official images. Version2.4.8is required due to a bug in earliergoreleaserversions that prevents theoverridessection in the.goreleaser.yamlfile from working (goreleaser/goreleaser#5298).A
.zipfile containing the binaries for each supported platform is uploaded as an artifact at the end of the job.