Add support for creating CHECK constraints with create_constraint
#464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I've found a bug in column duplication for unique indexes with multiple columns, so the example is failing. I am adding a fix in a separate PR. |
|
Bugfix: #466 |
|
It is highly likely we need to adjust the check constraint migrations as well. I will address those issues in a follow-up PR. |
Co-authored-by: Andrew Farries <andyrb@gmail.com>
Co-authored-by: Andrew Farries <andyrb@gmail.com>
Co-authored-by: Andrew Farries <andyrb@gmail.com>
Co-authored-by: Andrew Farries <andyrb@gmail.com>
Co-authored-by: Andrew Farries <andyrb@gmail.com>
andrew-farries
approved these changes
Nov 15, 2024
|
I guess this just needs to be rebased once #466 goes in? |
kvch
added a commit
that referenced
this pull request
Nov 18, 2024
Previously, unique and check constraints with multiple columns were not duplicated correctly. We had two issues: 1. Pgroll tried to create the same duplicated index for each renamed column. From now on pgroll creates the index once with the new column names. 2. Pgroll tried to convert the unique index to a constraint multiple times. From now on, the index is only converted once. Required by #464 --------- Co-authored-by: Andrew Farries <andyrb@gmail.com>
…traint-op-ii-check
|
Rebased and will merge once the tests pass. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new constraint
typetocreate_constraintoperation calledcheck. Now it is possible to create check constraints on multiple columns.Example
{ "name": "45_add_table_check_constraint", "operations": [ { "create_constraint": { "type": "check", "table": "tickets", "name": "check_zip_name", "columns": [ "sellers_name", "sellers_zip" ], "check": "sellers_name ~ 'Alice' AND sellers_zip IS NOT NULL", "up": { "sellers_name": "Alice", "sellers_zip": "(SELECT CASE WHEN sellers_zip IS NOT NULL THEN sellers_zip ELSE '00000' END)" }, "down": { "sellers_name": "sellers_name", "sellers_zip": "sellers_zip" } } } ] }