Remove some lint deprecation warnings #407
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And switch to use the new `copyloopvar` check for Go > 1.22
exekias
reviewed
Oct 16, 2024
| @@ -56,16 +56,13 @@ linters-settings: | |||
| - commentFormatting | |||
|
|
|||
| gofumpt: | |||
| lang-version: *goVersion | |||
There was a problem hiding this comment.
is this effectively changing the checks? would it be better to update goVersion up in this file?
There was a problem hiding this comment.
Yeah, that's something I forgot to update when upgrading to Go 1.23. Just changed it, let's see if all the lints still pass.
There was a problem hiding this comment.
@exekias All looks good now
There was a problem hiding this comment.
do we need to remove this line now then?
There was a problem hiding this comment.
I removed those lines because they were being flagged as deprecated by golangci-lint
exekias
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And switch to use the new
copyloopvarcheck for Go > 1.22