Don’t use dot imports for the syscall and unsafe packages #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Besides that using dot imports isn’t really idiomatic Go, in this case it actually breaks when using Go 1.11 Go 1.11 introduces a new `Pointer` type to the `syscall` package: https://golang.org/cl/106275 And since the `unsafe` package also contains a `Pointer` type, this now gives an error: `-: Pointer redeclared in this block` Not using dot imports for these packages solves that problem.
ellismg
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 29, 2018
Pick up a newer version of ssh-agent which has xanzy/ssh-agent#3 to fix go 1.11 build issues. Also, lock AppVeyor back to go 1.9, like we use on Travis.
ellismg
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 30, 2018
Pick up a newer version of ssh-agent which has xanzy/ssh-agent#3 to fix go 1.11 build issues. Also, lock AppVeyor back to go 1.9, like we use on Travis.
ellismg
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 30, 2018
Pick up a newer version of ssh-agent which has xanzy/ssh-agent#3 to fix go 1.11 build issues. Also, lock AppVeyor back to go 1.9, like we use on Travis.
ellismg
added a commit
to pulumi/pulumi
that referenced
this pull request
Aug 30, 2018
Pick up a newer version of ssh-agent which has xanzy/ssh-agent#3 to fix go 1.11 build issues. Also, lock AppVeyor back to go 1.9, like we use on Travis.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides that using dot imports isn’t really idiomatic Go, in this case it actually breaks when using Go 1.11 as it introduces a new
Pointertype to thesyscallpackage: https://golang.org/cl/106275And since the
unsafepackage also contains aPointertype, this now gives an error:-: Pointer redeclared in this blockNot using dot imports for these packages solves that problem. (fixes #2)