Checkstyle: Replaced property scope with new accessModifiers for JavadocVariable check #1241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
00b68b7 to
88f75d1
Compare
michitux
reviewed
Feb 19, 2025
...core/xwiki-commons-xml/src/main/java/org/xwiki/xml/internal/html/filter/SanitizerFilter.java
Outdated
Show resolved
Hide resolved
michitux
approved these changes
Feb 19, 2025
|
https://checkstyle.sourceforge.io/releasenotes.html#Release_10.22.0 during version bump for checkstyle, this PR should be merged |
|
@tmortagne , do you update versions by dependabot ? |
We are using Renovate for dependencies and plugins, but yes, we got a pull request yesterday, apparently. Will take care of that ASAP (probably later today or tomorrow). I had prepared https://jira.xwiki.org/browse/XCOMMONS-3263 with a mention for this issue, but thanks for the reminder :) |
|
Thanks for the help @kkoutsilis and @romani ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per upcoming changes in checkstyle/checkstyle#16049 for JavadocVariable check, this PR replaces scope with new accessModifiers property.
As the behavior of the check has changed to not account for the surrounding scope, some javadocs had to be added.
Note
This PR should be merged after the release of checkstyle 10.22.0