Skip to content

Add/fix chars in DEC graphics charset #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 3, 2020
Merged

Add/fix chars in DEC graphics charset #2679

merged 1 commit into from
Feb 3, 2020

Conversation

jerch
Copy link
Member

@jerch jerch commented Feb 2, 2020 •
edited
Loading

Adds/fixes the visual chars for some control codes in the DEC graphics charset.

Testable with: printf "\e(0[b][c][d][e][h][i]\e(B\n"

Closes #2678.

@jerch jerch changed the title fixing visual repr chars Add/fix chars in DEC graphics charset Feb 2, 2020
Tyriar
Tyriar approved these changes Feb 3, 2020
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find 👍

@Tyriar Tyriar added this to the 4.4.0 milestone Feb 3, 2020
@Tyriar Tyriar merged commit 12362ca into xtermjs:master Feb 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
4.4.0
Development

Successfully merging this pull request may close these issues.

Wrong chars in DEC graphics charset
2 participants
@jerch @Tyriar