Skip to content

Add PhantomJS test support and CharMeasure tests #535

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 15, 2017
Merged

Add PhantomJS test support and CharMeasure tests #535

merged 2 commits into from
Feb 15, 2017

Conversation

Tyriar
Copy link
Member

@Tyriar Tyriar commented Feb 9, 2017

Fixes #534

I figure it would be best to have these alongside the regular mocha tests so we can use import and other NodeJS calls conveniently so I've adopted the <module>.phantom.ts naming scheme.

@Tyriar Tyriar added this to the 2.4.0 milestone Feb 9, 2017
@Tyriar Tyriar self-assigned this Feb 9, 2017
@Tyriar Tyriar requested a review from parisk February 9, 2017 04:06
@Tyriar Tyriar mentioned this pull request Feb 10, 2017
Merged
parisk
parisk approved these changes Feb 15, 2017
View reviewed changes
Copy link
Contributor

@parisk parisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

@Tyriar Tyriar merged commit ade3389 into xtermjs:master Feb 15, 2017
@Tyriar Tyriar deleted the 534_phantomjs branch February 15, 2017 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@parisk parisk parisk approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
2.4.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Tyriar @parisk