Skip to content

Windows mode does not flag some conpty lines are wrapped #2666

New issue
New issue
Closed
#2667
Closed
Windows mode does not flag some conpty lines are wrapped#2666
#2667
Assignees
Tyriar
Labels
platform/windowstype/bugSomething is misbehaving
Milestone
4.4.0
@Tyriar

Description

@Tyriar
Tyriar
opened on Jan 7, 2020

Conpty moves to new lines using CUP, currently the wrapped line heuristic doesn't apply to it as it only works on LF:

xterm.js/src/common/WindowsMode.ts

Lines 9 to 27 in 1c06e57

export function handleWindowsModeLineFeed(bufferService: IBufferService): void {
// Winpty does not support wraparound mode which means that lines will never
// be marked as wrapped. This causes issues for things like copying a line
// retaining the wrapped new line characters or if consumers are listening
// in on the data stream.
//
// The workaround for this is to listen to every incoming line feed and mark
// the line as wrapped if the last character in the previous line is not a
// space. This is certainly not without its problems, but generally on
// Windows when text reaches the end of the terminal it's likely going to be
// wrapped.
const line = bufferService.buffer.lines.get(bufferService.buffer.ybase + bufferService.buffer.y - 1);
const lastChar = line?.get(bufferService.cols - 1);
const nextLine = bufferService.buffer.lines.get(bufferService.buffer.ybase + bufferService.buffer.y);
if (nextLine && lastChar) {
nextLine.isWrapped = (lastChar[CHAR_DATA_CODE_INDEX] !== NULL_CELL_CODE && lastChar[CHAR_DATA_CODE_INDEX] !== WHITESPACE_CELL_CODE);
}
}

VS Code issue: microsoft/vscode#85839

Metadata

Metadata

Assignees

Labels

platform/windowstype/bugSomething is misbehaving

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions