Fix mislabeled comments/mnemonic brief columns #3510
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✅ Download x64dbg 1.0.1961 (commit 0ec0cbf792 by @torusrxxx) |
|
Please wait until I find time to test it. |
|
A while back I did exactly the opposite 😅 4e5c2bd. My intention was to have the comment column first and then mnemonic brief, but I don't quite remember why this fixed the issue mentioned. |
03447d4 to
699342d
Compare
|
Finally had time to look into this properly. The original reason for the problem was that a new column was introduced in the middle (not at the end) and there was no new column config version created. To fix it I created |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3509 is because the order of ColComment and ColMnemonicBrief is not the same as the order they are added into the table.