Skip to content

Use Go DNS resolution in release binaries #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

Use Go DNS resolution in release binaries #691

merged 1 commit into from
Jun 30, 2023

Conversation

thebaer
Copy link
Member

@thebaer thebaer commented Apr 28, 2023

This builds with the netgo tag, ensuring WF binaries use Go DNS resolution instead of libc, preventing unhelpful errors when the application can't resolve addresses.

Closes #675

  • ☑ I have signed the CLA

@thebaer
Use Go DNS resolution in release binaries
3a7554a 
This builds with the `netgo` tag, ensuring WF binaries use Go DNS
resolution instead of libc, preventing unhelpful errors when the
application can't resolve addresses.

Closes #675
@thebaer thebaer added this to the 0.14 milestone Apr 28, 2023
@thebaer
Copy link
Member Author

thebaer commented Jun 30, 2023

Merging now.

@thebaer thebaer merged commit e037297 into develop Jun 30, 2023
@thebaer thebaer deleted the netgo branch June 30, 2023 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@fnyu fnyu fnyu approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Milestone
0.14
Development

Successfully merging this pull request may close these issues.

Segmentation fault from release binary
2 participants
@thebaer @fnyu