chore: expose array shapes for register_graphql_enum_type() $config #3373
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit aac3dc3 and detected 3 issues on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
There was a problem hiding this comment.
Copilot reviewed 2 out of 22 changed files in this pull request and generated no comments.
Files not reviewed (20)
- access-functions.php: Language not supported
- src/AppContext.php: Language not supported
- src/Data/Connection/AbstractConnectionResolver.php: Language not supported
- src/Data/DataSource.php: Language not supported
- src/Data/Loader/AbstractDataLoader.php: Language not supported
- src/Registry/TypeRegistry.php: Language not supported
- src/Request.php: Language not supported
- src/Router.php: Language not supported
- src/Server/ValidationRules/QueryDepth.php: Language not supported
- src/Server/WPHelper.php: Language not supported
- src/Type/Enum/ContentNodeIdTypeEnum.php: Language not supported
- src/Type/Enum/PluginStatusEnum.php: Language not supported
- src/Type/Enum/PostStatusEnum.php: Language not supported
- src/Type/Enum/TermNodeIdTypeEnum.php: Language not supported
- src/Type/Enum/UserNodeIdTypeEnum.php: Language not supported
- src/Type/WPEnumType.php: Language not supported
- src/Utils/InstrumentSchema.php: Language not supported
- src/Utils/QueryAnalyzer.php: Language not supported
- src/Utils/QueryLog.php: Language not supported
- src/Utils/Tracing.php: Language not supported
jasonbahl
approved these changes
May 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This PR improves the type hinting inside
WPEnumTypeto use explicit array shapes instead ofmixedwhenever possible, all the way through to theregister_graphql_enum_type()config array.Additionally, some complexity was removed via early returns, and the
PostStatusEnumwas refactored to fix a missing description.Important
This pr is based on #3368 which should be merged first.
Relevant diff: aac3dc3
Does this close any currently open issues?
Nope
Any other comments?
As part of #3354, we can update values to support a callable too, but it will take care to preserve the filters.