fix: [2.0] update DisableIntrospection rule to pass the enabled/disabled state to class instead of being re-defined within the class #3290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to class instead of being re-defined within the class - update the DisableIntrospection error message to provide more clarity -
Merged
justlevine
reviewed
Feb 4, 2025
src/Request.php
Outdated
Comment on lines
205
to
210
| // By default, introspection is disabled for non-logged-in users and when debug is off | ||
| $disable_introspection_rule_enabled = 0; | ||
| if ( ! get_current_user_id() && ! \WPGraphQL::debug() && 'off' === get_graphql_setting( 'public_introspection_enabled', 'off' ) ) { | ||
| $disable_introspection_rule_enabled = 1; | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we do this in the DisableIntrospection constructor instead of dirtying up request?
(Ref: I need a way to overload with this logic
There was a problem hiding this comment.
@justlevine pushed up some changes that handle it in the constructor and should allow for overloading like your example.
There was a problem hiding this comment.
Sorry my github is acting wonky: #3290 (comment)
justlevine
reviewed
Feb 4, 2025
justlevine
reviewed
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
This determines whether the DisableIntrospection rule is enabled before instantiating the rule.
Does this close any currently open issues?
related: #3247 (comment)