Skip to content

Fix update step for nightlies #6075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 2, 2025
Merged

Fix update step for nightlies #6075

merged 2 commits into from
Apr 2, 2025

Conversation

swissspidy
Copy link
Member

When using a currently nightly build and running wp cli update without any arguments, it couldn't find any version, which caused some PHP warnings.

$ wp cli update
PHP Warning:  Undefined array key "available" in phar:///Users/pascalb/.local/bin/wp/vendor/wp-cli/wp-cli/php/commands/src/CLI_Command.php on line 330

Warning: Undefined array key "available" in phar:///Users/pascalb/.local/bin/wp/vendor/wp-cli/wp-cli/php/commands/src/CLI_Command.php on line 330
PHP Warning:  Trying to access array offset on null in phar:///Users/pascalb/.local/bin/wp/vendor/wp-cli/wp-cli/php/commands/src/CLI_Command.php on line 334

Warning: Trying to access array offset on null in phar:///Users/pascalb/.local/bin/wp/vendor/wp-cli/wp-cli/php/commands/src/CLI_Command.php on line 334
You have version 2.12.0-alpha-842fe5d. Would you like to update to ? [y/n]

That's because $update['available'] doesn't exist. The right array key & check is $update['status'] === 'available' 🤦

@swissspidy swissspidy added this to the 2.12.0 milestone Apr 2, 2025
@swissspidy swissspidy requested a review from a team as a code owner April 2, 2025 10:01
@codecov Codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
php/commands/src/CLI_Command.php 0.00% 5 Missing ⚠️

📢 Thoughts on this report? Let us know!

@swissspidy swissspidy merged commit 2e2c3c8 into main Apr 2, 2025
49 of 52 checks passed
@swissspidy swissspidy deleted the fix/update-check branch April 2, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
command:cli-update
Projects
None yet
Milestone
2.12.0
Development

Successfully merging this pull request may close these issues.
2 participants
@swissspidy @mrsdizzie