Skip to content

Conversation

bor0
Copy link
Contributor

@bor0 bor0 commented Nov 25, 2024

Use a more recent version of php-cli-tools to address PHP 8.4 warnings.

Without this PR:

bor0:~/dev/www$ ~/dev/wp-cli/bin/wp plugin list
PHP Deprecated:  cli\Table::__construct(): Implicitly marking parameter $headers as nullable is deprecated, the explicit nullable type must be used instead in /Users/bor0/dev/wp-cli/vendor/wp-cli/php-cli-tools/lib/cli/Table.php on line 47
Deprecated: cli\Table::__construct(): Implicitly marking parameter $headers as nullable is deprecated, the explicit nullable type must be used instead in /Users/bor0/dev/wp-cli/vendor/wp-cli/php-cli-tools/lib/cli/Table.php on line 47
PHP Deprecated:  cli\Table::__construct(): Implicitly marking parameter $rows as nullable is deprecated, the explicit nullable type must be used instead in /Users/bor0/dev/wp-cli/vendor/wp-cli/php-cli-tools/lib/cli/Table.php on line 47
Deprecated: cli\Table::__construct(): Implicitly marking parameter $rows as nullable is deprecated, the explicit nullable type must be used instead in /Users/bor0/dev/wp-cli/vendor/wp-cli/php-cli-tools/lib/cli/Table.php on line 47
PHP Deprecated:  cli\Table::__construct(): Implicitly marking parameter $footers as nullable is deprecated, the explicit nullable type must be used instead in /Users/bor0/dev/wp-cli/vendor/wp-cli/php-cli-tools/lib/cli/Table.php on line 47
Deprecated: cli\Table::__construct(): Implicitly marking parameter $footers as nullable is deprecated, the explicit nullable type must be used instead in /Users/bor0/dev/wp-cli/vendor/wp-cli/php-cli-tools/lib/cli/Table.php on line 47
+------------------------------------------+----------+------------------------------+-----------+----------------+-------------+
| name                                     | status   | update                       | version   | update_version | auto_update |
+------------------------------------------+----------+------------------------------+-----------+----------------+-------------+
| Basic-Auth                               | inactive | none                         | 0.1       |                | off         |
| keyring                                  | inactive | none                         | 3.0       |                | off         |
| woocommerce                              | inactive | version higher than expected | 9.6.0-dev |                | off         |
+------------------------------------------+----------+------------------------------+-----------+----------------+-------------+

With this PR, the warnings are gone.

Use a more recent version of `php-cli-tools` to address PHP 8.4 warnings
@bor0 bor0 requested a review from a team as a code owner November 25, 2024 13:15
@swissspidy swissspidy changed the title PHP 8.4 nullable parameters Update wp-cli/php-cli-tools Nov 25, 2024
@swissspidy swissspidy merged commit 349cf0c into wp-cli:main Nov 25, 2024
43 of 46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants