Skip to content

Conversation

grafruessel
Copy link
Contributor

updated copyright years

updated copyright years
@grafruessel grafruessel requested a review from a team as a code owner April 28, 2024 18:18
@ernilambar
Copy link
Member

Standard format of MIT license is:

Copyright <YEAR> <COPYRIGHT HOLDER>

So this should have been like this:

Copyright (C) 2011 WP-CLI Development Group (https://github.com/wp-cli/wp-cli/contributors)

I noticed similar in our other repos also. Should this format be adopted? Otherwise we would have to update year in license file every year. 😀

CC @danielbachhuber @swissspidy

@swissspidy
Copy link
Member

I don't see a need to update copyright years every year, but if we wanna do it, we should automate it and do it across all repos. But yeah it doesn't seem worth it.

/cc @wp-cli/maintainers

@ernilambar
Copy link
Member

From what I have understood, <YEAR> is the year copyright was applied. So there wont be any need for automation for changing years if we follow that standard.

@danielbachhuber
Copy link
Member

From what I have understood, <YEAR> is the year copyright was applied. So there wont be any need for automation for changing years if we follow that standard.

Today I learned!

It looks like WordPress core takes the range approach though, so let's continue to follow that: WordPress/wordpress-develop@7aa146d

@ernilambar
Copy link
Member

I tried this action and it is working good. https://github.com/FantasticFiasco/action-update-license-year
It was successful to create PR with proper year update. https://github.com/ernilambar/permit/pull/2/files

@ernilambar
Copy link
Member

OR we could create CLI command in https://github.com/wp-cli/wp-cli-dev/ which would be run by the maintainer once a year. This command should preferably update year for all repos and create respective PR in the repo.

@swissspidy swissspidy changed the title Update LICENSE Update copyright year in license Aug 6, 2024
@swissspidy
Copy link
Member

Let's handle the automation in a new issue

@swissspidy swissspidy added this to the 2.11.0 milestone Aug 6, 2024
@swissspidy swissspidy merged commit d5142f0 into wp-cli:main Aug 6, 2024
@grafruessel grafruessel deleted the patch-1 branch October 16, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants