Skip to content

Update docker runner to resolve docker path using /usr/bin/env #5936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 26, 2024
Merged

Update docker runner to resolve docker path using /usr/bin/env #5936

merged 2 commits into from
Apr 26, 2024

Conversation

thelovekesh
Copy link
Member

Sometimes, the WP CLI process doesn't have access to PATH and it gives an error. This PR aims to resolve those binary using env which is already done for binaries like mysql.

Related: #5935

@thelovekesh thelovekesh requested a review from a team as a code owner April 26, 2024 08:16
swissspidy
swissspidy reviewed Apr 26, 2024
View reviewed changes
@thelovekesh thelovekesh requested a review from swissspidy April 26, 2024 09:06
@swissspidy swissspidy added this to the 2.11.0 milestone Apr 26, 2024
@thelovekesh
Copy link
Member Author

@swissspidy Should we change these occurrences with Utils\force_env_on_nix_systems()?

wp-cli/php/utils.php

Line 1782 in 46051ea

$result = Process::create( '/usr/bin/env which mysql', null, null )->run();

@swissspidy
Copy link
Member

Probably? cc @schlessera for 2nd opinion

@schlessera schlessera merged commit d1f69d8 into wp-cli:main Apr 26, 2024
@thelovekesh thelovekesh deleted the patch-1 branch April 26, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
scope:framework
Projects
None yet
Milestone
2.11.0
Development

Successfully merging this pull request may close these issues.
3 participants
@thelovekesh @swissspidy @schlessera