Skip to content

Conversation

Roy-Orbison
Copy link
Contributor

Further to #5873, I incorrectly handled options that end in = and have already been completed. Any candidates offered immediately after such an option are treated by shells as possible values to concatenate, not possible names of the current option. Consequently, this

wp config create --dbname=

will tab-complete to

wp config create --dbname=--dbname=

I have added an extra condition to prevent that case.

@Roy-Orbison Roy-Orbison requested a review from a team as a code owner March 6, 2024 05:29
Copy link
Member

@danielbachhuber danielbachhuber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@danielbachhuber danielbachhuber merged commit a76265b into wp-cli:main Mar 7, 2024
@Roy-Orbison Roy-Orbison deleted the completion-fix-fix branch March 8, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants