Skip to content

Fix PHP 8.1 deprecation: ReturnTypeWillChange #5807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

Fix PHP 8.1 deprecation: ReturnTypeWillChange #5807

merged 1 commit into from
Jun 21, 2023

Conversation

Soean
Copy link
Contributor

@Soean Soean commented Jun 21, 2023

Fixes PHP 8.1 deprecation by adding #[\ReturnTypeWillChange] to Iterator methods.

Fixes #5806

@Soean Soean requested a review from a team as a code owner June 21, 2023 08:05
@swissspidy swissspidy merged commit 90be24d into wp-cli:main Jun 21, 2023
@swissspidy swissspidy added this to the 2.9.0 milestone Jun 21, 2023
@Soean Soean deleted the 5806 branch June 27, 2023 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
bug scope:framework
Projects
None yet
Milestone
2.9.0
Development

Successfully merging this pull request may close these issues.

PHP 8.1 deprecation: Return type of WP_CLI\Iterators\Query
2 participants
@Soean @swissspidy