Skip to content

Conversation

schlessera
Copy link
Member

Given the haphazard nature of Requests version permutations, this PR ignores Requests deprecation messages in error handling for now if they are the sole output on STDERR.

This is done:

  • to avoid unnecessary breakage in automated CI/CD pipelines
  • to simplify testing within the WP-CLI project

This should only be seen as a temporary fix until we have a better solution for dealing with Requests as a dependency shared between WP Core and WP-CLI.

@schlessera schlessera requested a review from a team as a code owner May 31, 2023 06:51
@schlessera schlessera added this to the 2.8.0 milestone May 31, 2023
@schlessera schlessera merged commit 8b625ab into main May 31, 2023
@schlessera schlessera deleted the fix/ignore-request-deprecations branch May 31, 2023 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant