Extract Requests out of Composer #5796
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #5795
When using Composer to pull in both WordPress Core and WP-CLI, the static files autoloading that Composer applies to the Requests library causes fatal issues.
This PR extract the Requests library out of the Composer dependencies and it commits it as part of the source. We had already been manually controlling the autoloading of the Requests library to get around the lack of WordPress Core dependency management, so this step only completes the approach we've already been taking.
Note that this is certainly not the correct way of handling a dependency. However, the combination of how WordPress doesn't handle its dependencies and the requirement of WP-CLI to work across all permutations of old/new Core and old/new WP-CLI forces our hand in this case.